Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build new docker images in build_model with in-memory Dockerfile #280

Merged
merged 5 commits into from
Sep 2, 2017
Merged

Build new docker images in build_model with in-memory Dockerfile #280

merged 5 commits into from
Sep 2, 2017

Conversation

dcrankshaw
Copy link
Contributor

Removes the need to write a Dockerfile to disk in the user's file system by creating an in-memory Dockefile with StringIO then adding it directly to a temporary tar file to be used as the Docker build context.

The end result is that we don't write (and potentially overwrite) Dockerfile's in the user's system.

@dcrankshaw dcrankshaw added this to the 0.2 Release milestone Sep 1, 2017
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/681/
Test FAILed.

@dcrankshaw
Copy link
Contributor Author

jenkins test this please

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/683/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/684/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/685/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/686/
Test PASSed.

@dcrankshaw dcrankshaw force-pushed the build_image_no_dockerfile branch from bf173b4 to ce60e21 Compare September 2, 2017 05:53
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/689/
Test PASSed.

Corey-Zumar
Corey-Zumar requested changes Sep 2, 2017
View reviewed changes
Copy link
Contributor

@Corey-Zumar Corey-Zumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Part two of the tutorial needs to be updated to remove the force argument from build_and_deploy_model. Once that's done, I'll merge.

@dcrankshaw
Copy link
Contributor Author

dcrankshaw commented Sep 2, 2017 via email

Corey-Zumar
Corey-Zumar approved these changes Sep 2, 2017
View reviewed changes
Copy link
Contributor

@Corey-Zumar Corey-Zumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/693/
Test PASSed.

@Corey-Zumar Corey-Zumar merged commit 692bbed into ucbrise:develop Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corey-Zumar Corey-Zumar Corey-Zumar approved these changes

Assignees
No one assigned
Labels
status: accepted type: maintenance
Projects
None yet
Milestone
0.2 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@dcrankshaw @AmplabJenkins @Corey-Zumar